Enable keeper fault injection for inserts in functional tests#43117
Merged
devcrafter merged 2 commits intomasterfrom Nov 17, 2022
Merged
Enable keeper fault injection for inserts in functional tests#43117devcrafter merged 2 commits intomasterfrom
devcrafter merged 2 commits intomasterfrom
Conversation
funcntional tests
47c1a5b to
b12ebab
Compare
Member
|
Some stress tests fail with 'Cannot start clickhouse-server', could this be related to the change ? |
Member
Author
|
@tavplubix is this PR valid way to enable ZK fault injections for inserts in tests? |
Member
|
Yep, it looks valid |
Member
Author
|
Test failures:
The simplest we can do - is to increase timeout. A bit more sophisticated - retries for inserts on test side. We could use keeper retries on insert as well, but then we need to get from query_log time to execute the query - it'll make the test more complicated. @tavplubix WDYT? |
Member
|
|
Member
Author
Fixed in #43326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Follow up #42607 #43122