You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not for changelog (changelog entry is not required)
cc @devcrafter
it's a simple fix, 10 Creates guarantee at least 10 ZXID, not 14 (before ZXID was increased with RAFT log idx so it was higher).
It's interesting how it didn't fail before, the same cluster is reused for all tests in module so ZXID was increased by other tests.
All stress tests failed because of Code: 115. DB::Exception: Setting insert_keeper_max_retries is neither a builtin setting nor started with the prefix 'custom_'... @devcrafter I guess it's the new setting introduced by you. Not sure how we handle the addition of new settings in regard to BC tests but pinging you just in case.
All stress tests failed because of Code: 115. DB::Exception: Setting insert_keeper_max_retries is neither a builtin setting nor started with the prefix 'custom_'...@devcrafter I guess it's the new setting introduced by you. Not sure how we handle the addition of new settings in regard to BC tests but pinging you just in case.
That's most probably because this PR branch was created from commit with merged #42607 which was reverted later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
robot-ch-test-poll
added
the
pr-not-for-changelog
Changelog category (leave one):
cc @devcrafter
it's a simple fix, 10 Creates guarantee at least 10 ZXID, not 14 (before ZXID was increased with RAFT log idx so it was higher).
It's interesting how it didn't fail before, the same cluster is reused for all tests in module so ZXID was increased by other tests.