Fix TSan errors (correctly ignore _exit interception)#43009
Merged
tavplubix merged 2 commits intoClickHouse:masterfrom Nov 7, 2022
Merged
Fix TSan errors (correctly ignore _exit interception)#43009tavplubix merged 2 commits intoClickHouse:masterfrom
tavplubix merged 2 commits intoClickHouse:masterfrom
Conversation
tavplubix
approved these changes
Nov 7, 2022
Member
tavplubix
left a comment
tavplubix
left a comment
There was a problem hiding this comment.
LOL, nice catch, thank you! Could you please add a comment about importance of this include?
robot-ch-test-poll2
added
the
pr-not-for-changelog
Because safeExit() does not includes header with defines, it does not know about THREAD_SANITIZER. And it also fixes Azure blob storage, actually everything is fine with the sdk itself, the problem is only in TSan that intercepts _exit() and report leak, even thoug that tread will be joined later. Refs: ClickHouse#23056 (ClickHouse#23616) Fixes: ClickHouse#38474 Closes: ClickHouse#42640 Fixes: ClickHouse#42638 Fixes: ClickHouse#34988 Cc: @alexey-milovidov, @tavplubix Signed-off-by: Azat Khuzhin <[email protected]>
Merged
Member
|
Ha-ha, now build fails because of |
Member
|
Builds are ok |
Member
Author
Member
Author
|
By the way, maybe it worth to backport for CI over release branches? |
tavplubix
added
the
pr-must-backport
This was referenced Nov 10, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 10, 2022
robot-clickhouse
added
the
pr-backports-created
tavplubix
added a commit
that referenced
this pull request
Nov 11, 2022
Backport #43009 to 22.10: Fix TSan errors (correctly ignore _exit interception)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix TSan errors (correctly ignore _exit interception)
Because safeExit() does not includes header with defines, it does not know about THREAD_SANITIZER.
And it also fixes Azure blob storage, actually everything is fine with the sdk itself, the problem is only in TSan that intercepts _exit() and report leak, even thoug that tread will be joined later.
Refs: #23056 (#23616)
Fixes: #38474
Closes: #42640
Fixes: #42638
Fixes: #34988
Cc: @alexey-milovidov, @tavplubix