Implement optimize_redundant_functions_in_order_by on top of QueryTree.#42970
Merged
kitaisreal merged 8 commits intomasterfrom Jan 13, 2023
Merged
Implement optimize_redundant_functions_in_order_by on top of QueryTree.#42970kitaisreal merged 8 commits intomasterfrom
kitaisreal merged 8 commits intomasterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
kitaisreal
suggested changes
Nov 4, 2022
kitaisreal
approved these changes
Nov 17, 2022
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
novikd
force-pushed
the
optimize-redundant-function
branch
from
eb9191e to
0ecf616
Compare
kitaisreal
suggested changes
Jan 3, 2023
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
src/Analyzer/Passes/OptimizeRedundantFunctionsInOrderByPass.cpp
Outdated
Show resolved
Hide resolved
Member
Author
|
@kitaisreal I fixed all the review issues |
kitaisreal
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Implement
optimize_redundant_functions_in_order_byon top of QueryTree. Part of #42648.