Skip to content

42414 enable functions in readonly mode#42708

Merged
SmitaRKulkarni merged 8 commits intomasterfrom
42414_Enable_functions_in_readonly_mode
Nov 8, 2022
Merged

42414 enable functions in readonly mode#42708
SmitaRKulkarni merged 8 commits intomasterfrom
42414_Enable_functions_in_readonly_mode

Conversation

@SmitaRKulkarni
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni commented Oct 26, 2022

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added new field allow_readonly in system.table_functions to allow using table functions in readonly mode resolves #42414
Implementation:

  • Added a new field allow_readonly to table system.table_functions.
  • Updated to use new field allow_readonly to allow using table functions in readonly mode.
    Testing:
  • Added a test for filesystem tests/queries/0_stateless/02473_functions_in_readonly_mode.sh
    Documentation:
  • Updated the english documentation for Table Functions.

…ng table functions in readonly mode.

Implementation:
* Added a new field allow_readonly to table system.table_functions.
* Updated to use new field allow_readonly to allow using table functions in readonly mode.
* Added TableFunctionProperties similar to AggregateFunctionProperties.
* The functions allowed in readonly mode are in this set table_functions_allowed_in_readonly_mode.
Testing:
* Added a test for filesystem tests/queries/0_stateless/02473_functions_in_readonly_mode.sh
Documentation:
* Updated the english documentation for Table Functions.
@SmitaRKulkarni SmitaRKulkarni marked this pull request as draft October 26, 2022 16:51
@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Oct 26, 2022
@SmitaRKulkarni SmitaRKulkarni marked this pull request as ready for review October 27, 2022 12:50
@evillique evillique self-assigned this Oct 27, 2022
…nput , moved table_functions_allowed_in_readonly_mode inside TableFunctionFactory- 42414 Enable table functions in readonly mode
…llowed_in_readonly_mode - 42414 Enable table functions in readonly mode
@SmitaRKulkarni
Copy link
Copy Markdown
Member Author

Unrelated test fails
AST fuzzer (asan) - Failed due to null dereference in DB::KeyCondition
Integration tests - test_tcp_handler_interserver_listen_host/test_case.py::test_request_to_node_without_interserver_listen_host - test passed in other integration tests
Stress test (asan/msan/ubsan) - OOM killer - unrelated to this change
Stress test (debug) - Failed due to backward compatibility check
Stress test (tsan) - Failed due to thread leak in azure

@SmitaRKulkarni SmitaRKulkarni merged commit 658036d into master Nov 8, 2022
@SmitaRKulkarni SmitaRKulkarni deleted the 42414_Enable_functions_in_readonly_mode branch November 8, 2022 14:22
@alexey-milovidov alexey-milovidov mentioned this pull request Nov 20, 2022
yokofly pushed a commit to timeplus-io/proton that referenced this pull request Mar 1, 2025
* Bump protobuf to v3.18.x (ref: ClickHouse/ClickHouse#50400)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#55963)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#50920)

* Update contribe/orc (ref: ClickHouse/ClickHouse#53324)

* Bump protobuf to v21.9 (ref: ClickHouse/ClickHouse#56014)

* Removed unused code in google-protobuf-cmake/CMakeLists.txt (ref: ClickHouse/ClickHouse#56102)

* Bump gRPC to v1.55.4 and protobuf to v22.5 (ref: ClickHouse/ClickHouse#56664)

* Bump gRPC to v1.59 and protobuf to v24.4 (ref: ClickHouse/ClickHouse#56853)

* enable functions in readonly mode (ref: ClickHouse/ClickHouse#42708)

* Introduce more fields for in-source function documentation (ref: ClickHouse/ClickHouse#49300)

* Add ability to convert timeplusd table structure to CapnProto/Protobuf format schema (ref: ClickHouse/ClickHouse#52278)

* Well known protos (ref: ClickHouse/ClickHouse#56741)

* Update protobuf to v25.1 (ref: ClickHouse/ClickHouse#58020)

* fixed unit_tests_dbms build

* Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) (ref: ClickHouse/ClickHouse#68267)

* fixed reigsterFunction

* fixed error after rebase
yokofly added a commit to timeplus-io/proton that referenced this pull request Mar 1, 2025
* Bump protobuf to v3.18.x (ref: ClickHouse/ClickHouse#50400)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#55963)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#50920)

* Update contribe/orc (ref: ClickHouse/ClickHouse#53324)

* Bump protobuf to v21.9 (ref: ClickHouse/ClickHouse#56014)

* Removed unused code in google-protobuf-cmake/CMakeLists.txt (ref: ClickHouse/ClickHouse#56102)

* Bump gRPC to v1.55.4 and protobuf to v22.5 (ref: ClickHouse/ClickHouse#56664)

* Bump gRPC to v1.59 and protobuf to v24.4 (ref: ClickHouse/ClickHouse#56853)

* enable functions in readonly mode (ref: ClickHouse/ClickHouse#42708)

* Introduce more fields for in-source function documentation (ref: ClickHouse/ClickHouse#49300)

* Add ability to convert timeplusd table structure to CapnProto/Protobuf format schema (ref: ClickHouse/ClickHouse#52278)

* Well known protos (ref: ClickHouse/ClickHouse#56741)

* Update protobuf to v25.1 (ref: ClickHouse/ClickHouse#58020)

* fixed unit_tests_dbms build

* Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) (ref: ClickHouse/ClickHouse#68267)

* fixed reigsterFunction

* fixed error after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table functions cluster and clusterAllReplicas can be enabled in readonly mode.

3 participants