Closed
Conversation
robot-ch-test-poll
added
pr-backward-incompatible
This was referenced Oct 27, 2022
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Nov 7, 2022
Because safeExit() does not includes header with defines, it does not know about THREAD_SANITIZER. And it also fixes Azure blob storage, actually everything is fine with the sdk itself, the problem is only in TSan that intercepts _exit() and report leak, even thoug that tread will be joined later. Refs: ClickHouse#23056 (ClickHouse#23616) Fixes: ClickHouse#38474 Closes: ClickHouse#42640 Fixes: ClickHouse#42638 Fixes: ClickHouse#34988 Cc: @alexey-milovidov, @tavplubix Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Azure Blob Storage is temporarily removed due to a thread leak (see Azure/azure-sdk-for-cpp#4047). This closes #42638. Please help bring it back.