Fix possible errors on restart of ReplicatedMergeTree after failed quorum insert#42509
Closed
CurtizJ wants to merge 4 commits intoClickHouse:masterfrom
Closed
Fix possible errors on restart of ReplicatedMergeTree after failed quorum insert#42509CurtizJ wants to merge 4 commits intoClickHouse:masterfrom
ReplicatedMergeTree after failed quorum insert#42509CurtizJ wants to merge 4 commits intoClickHouse:masterfrom
Conversation
robot-ch-test-poll2
added
the
pr-bugfix
Member
Author
|
Partially related #9712. |
devcrafter
reviewed
Oct 21, 2022
Member
devcrafter
left a comment
devcrafter
left a comment
There was a problem hiding this comment.
I've tried to run the test w/o changes in ReplicatedMergeTreeSink.cpp. It didn't fail but, I guess, it supposed to.
| function thread2 { | ||
| for x in {100..199}; do | ||
| while true; do | ||
| $CLICKHOUSE_CLIENT --query "DETACH TABLE r$1" |
Member
There was a problem hiding this comment.
It would be nice to have some comment regarding why we're doing here 'detach/attach'
alexey-milovidov
approved these changes
Dec 26, 2022
alexey-milovidov
removed
the
pr-bugfix
robot-ch-test-poll4
added
the
pr-not-for-changelog
devcrafter
force-pushed
the
fix-restart-after-quorum-insert
branch
from
a91eb16 to
0d42831
Compare
+ renamePartToTemporary() lambda to reused code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible errors
The local set of parts of table ... doesn't look like the set of parts in ZooKeeperon restart ofReplicatedMergeTreeafter failed quorum insert and detaching of table or restarting server.