Attempt to fix abort from parallel parsing#42496
Merged
nikitamikhaylov merged 6 commits intomasterfrom Oct 20, 2022
Merged
Conversation
robot-ch-test-poll2
added
the
pr-not-for-changelog
devcrafter
reviewed
Oct 19, 2022
azat
reviewed
Oct 20, 2022
src/Common/ThreadPool.h
Outdated
| /// thread->join(); | ||
| /// Where join() won't be executed in case when we call it | ||
| /// from the same std::thread and it will end to std::abort(). | ||
| if (state->finished) |
Member
There was a problem hiding this comment.
But joining the thread (std::thread, pthread) from itself is UB, in reality it will likely hang.
Maybe it is better to keep this function consistent with std::thread and leave it as-is.
And instead implicitly reset the state if it is finished in the dtor?
Member
Author
There was a problem hiding this comment.
Ok. I also had an idea to make this abstraction similar to std::jthread (auto joinable in destructor)
azat
reviewed
Oct 20, 2022
KochetovNicolai
added a commit
that referenced
this pull request
Oct 20, 2022
This reverts commit 4d703b7.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
This closes #42009
CC @azat