Skip to content

Better workaround for emitting .debug_aranges section#42457

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:build/better-lld-wrapper
Oct 20, 2022
Merged

Better workaround for emitting .debug_aranges section#42457
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:build/better-lld-wrapper

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Oct 18, 2022

Note, that this is just a syntastic change, that should not makes any difference (well the only difference is that now it supports gold and other links, since the option is handled by the plugin itself instead of the linker).

Refs: https://reviews.llvm.org/D133092

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Follow-up for: #40873

Note, that this is just a syntastic change, that should not makes any
difference (well the only difference is that now it supports gold and
other links, since the option is handled by the plugin itself instead of
the linker).

Refs: https://reviews.llvm.org/D133092
Signed-off-by: Azat Khuzhin <[email protected]>
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 18, 2022
@alexey-milovidov alexey-milovidov self-assigned this Oct 18, 2022
@azat
Copy link
Copy Markdown
Member Author

azat commented Oct 19, 2022

02420_stracktrace_debug_symbols passed

@alexey-milovidov alexey-milovidov merged commit 61ed0a5 into ClickHouse:master Oct 20, 2022
@alexey-milovidov
Copy link
Copy Markdown
Member

@azat any idea why this test can fail?

@azat azat deleted the build/better-lld-wrapper branch October 20, 2022 07:20
@azat
Copy link
Copy Markdown
Member Author

azat commented Oct 20, 2022

@azat any idea why this test can fail?

Looks like an issue in bash that we bumped into.
Let's try this one - #42522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants