Increase request_timeout_ms for s3 disks.#42321
Merged
Conversation
robot-ch-test-poll
added
the
pr-improvement
kssenii
approved these changes
Oct 14, 2022
filimonov
added
pr-must-backport
alexey-milovidov
removed
the
pr-must-backport
Contributor
Author
|
Motivation for backport So we can call it also a bug fix, because it removes the regression. |
filimonov
added
the
pr-must-backport
alexey-milovidov
removed
the
pr-must-backport
Member
02267_file_globs_schema_inference |
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jan 23, 2023
…_timeout_ms Increase request_timeout_ms for s3 disks.
Enmk
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Jan 24, 2023
…ut_ms_42321 22.8 Backport of ClickHouse#42321 s3 request_timeout_ms
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Feb 7, 2023
…_timeout_ms Increase request_timeout_ms for s3 disks.
Member
|
This change introduced disastrous consequences - now, reading from S3 has high latencies going up to 30, 60, and 90 seconds - not compatible with production workloads. We have rolled back this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When uploading big parts to minio, 'Complete Multipart Upload' can take a long time.
Minio sends heartbeats every 10 seconds (see minio/minio#7198). But clickhouse times out earlier, because the default send/receive timeout is set to 5 seconds.