system.detached_parts add column bytes_on_disk and path#42303
Merged
kssenii merged 20 commits intoClickHouse:masterfrom Nov 8, 2022
Merged
system.detached_parts add column bytes_on_disk and path#42303kssenii merged 20 commits intoClickHouse:masterfrom
kssenii merged 20 commits intoClickHouse:masterfrom
Conversation
kssenii
added
the
can be tested
robot-ch-test-poll1
added
pr-improvement
kssenii
reviewed
Oct 14, 2022
kssenii
reviewed
Oct 14, 2022
kssenii
reviewed
Oct 16, 2022
kssenii
reviewed
Oct 19, 2022
kssenii
reviewed
Nov 2, 2022
kssenii
approved these changes
Nov 7, 2022
Member
|
@kssenii it does not avoid heavy calculations if the new column was not queried. |
tavplubix
reviewed
Jan 11, 2023
| new_columns[i++]->insert(info.table); | ||
| new_columns[i++]->insert(p.valid_name ? p.partition_id : Field()); | ||
| new_columns[i++]->insert(p.dir_name); | ||
| new_columns[i++]->insert(calculateTotalSizeOnDisk(p.disk, fs::path(info.data->getRelativeDataPath()) / detached_part_path)); |
Member
There was a problem hiding this comment.
It may slow down select ... from system.detached_parts significantly, especially if object storage is involved. Moreover, a query slows down even if the bytes_on_disk column is not queried. We should not calculate bytes_on_disk if it was not queried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add columns
bytes_on_diskandpathtosystem.detached_parts. Closes #42264.