Skip to content

ColumnVector: optimize UInt8 index with AVX512VBMI#41247

Merged
nickitat merged 8 commits intoClickHouse:masterfrom
guowangy:vectorIndexImplVBMI
Sep 22, 2022
Merged

ColumnVector: optimize UInt8 index with AVX512VBMI#41247
nickitat merged 8 commits intoClickHouse:masterfrom
guowangy:vectorIndexImplVBMI

Conversation

@guowangy
Copy link
Copy Markdown
Contributor

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

ColumnVector: optimize UInt8 index with AVX512VBMI

The patch set can have about 5% performance gain in SSB (SF=100) query 3.3, 3.4
(tested on Icelake: Xeon 8380 * 2 socket).

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Sep 13, 2022
@nickitat nickitat self-assigned this Sep 13, 2022
@nickitat nickitat added the can be tested Allows running workflows for external contributors label Sep 15, 2022
@nickitat nickitat merged commit 8de524c into ClickHouse:master Sep 22, 2022
alexey-milovidov added a commit that referenced this pull request Sep 26, 2022
alexey-milovidov added a commit that referenced this pull request Sep 27, 2022
Revert "ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)"
robot-clickhouse pushed a commit that referenced this pull request Sep 27, 2022
robot-clickhouse pushed a commit that referenced this pull request Sep 27, 2022
robot-clickhouse pushed a commit that referenced this pull request Sep 27, 2022
alexey-milovidov added a commit that referenced this pull request Sep 27, 2022
Backport #41797 to 22.8: Revert "ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)"
alexey-milovidov added a commit that referenced this pull request Sep 27, 2022
Backport #41797 to 22.9: Revert "ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)"
alexey-milovidov added a commit that referenced this pull request Sep 27, 2022
Backport #41797 to 22.7: Revert "ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)"
@yakov-olkhovskiy
Copy link
Copy Markdown
Member

@guowangy @nickitat bug found by fuzzer:
#41859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants