Skip to content

tests: fix 01281_group_by_limit_memory_tracking flakiness#41178

Merged
nickitat merged 2 commits intoClickHouse:masterfrom
azat:tests/fix-01281_group_by_limit_memory_tracking
Sep 11, 2022
Merged

tests: fix 01281_group_by_limit_memory_tracking flakiness#41178
nickitat merged 2 commits intoClickHouse:masterfrom
azat:tests/fix-01281_group_by_limit_memory_tracking

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Sep 10, 2022

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 10, 2022
Copy link
Copy Markdown
Member

@nickitat nickitat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that making the query single-threaded is a better solution, but I also have nothing against it

@nickitat nickitat self-assigned this Sep 10, 2022
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 10, 2022

While rewriting the test in ClickHouse#11119 it looses LIMIT, which makes the test
useless, see details in ClickHouse#11022

Signed-off-by: Azat Khuzhin <[email protected]>
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 10, 2022

I'm not sure that making the query single-threaded is a better solution, but I also have nothing against it

For this particular test I think it is fine, since it is about memory consumption, more details can be found here #11022
Actually while rewriting the test in #11119 it looses it's ability to reproduce the problem, will fix it.

@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 11, 2022

Test failures looks unrelated:

Integration tests (release) [2/2] — fail: 1, passed: 1133, flaky: 0

Stateful tests (debug) — fail: 1, passed: 127, skipped: 2

  • 00168_parallel_processing_on_replicas_part_1 - timeout, x2, 1200 sec instead of 600

Stateless tests (debug, s3 storage) [2/3] — fail: 3, passed: 1437, skipped: 37

  • 01516_drop_table_stress_long - timeout
  • 01195_formats_diagnostic_info - timeout
  • 01085_max_distributed_connections - timeout

@nickitat nickitat merged commit 13f7a82 into ClickHouse:master Sep 11, 2022
@azat azat deleted the tests/fix-01281_group_by_limit_memory_tracking branch September 19, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants