Skip to content

SSH keys authentication#41109

Merged
nikitamikhaylov merged 53 commits intoClickHouse:masterfrom
InfJoker:ssh-plain-authentication
Sep 26, 2023
Merged

SSH keys authentication#41109
nikitamikhaylov merged 53 commits intoClickHouse:masterfrom
InfJoker:ssh-plain-authentication

Conversation

@InfJoker
Copy link
Copy Markdown
Contributor

@InfJoker InfJoker commented Sep 8, 2022 •
edited by nikitamikhaylov
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added new type of authentication based on SSH keys. It works only for Native TCP protocol.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@robot-clickhouse robot-clickhouse added pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR. labels Sep 8, 2022
@InfJoker InfJoker force-pushed the ssh-plain-authentication branch 3 times, most recently from cdbbf4d to c70bdb4 Compare September 8, 2022 15:19
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Sep 8, 2022
@InfJoker InfJoker force-pushed the ssh-plain-authentication branch 2 times, most recently from 529fbb2 to e1d0e03 Compare September 8, 2022 21:57
@nikitamikhaylov nikitamikhaylov self-assigned this Sep 9, 2022
@InfJoker InfJoker force-pushed the ssh-plain-authentication branch 5 times, most recently from 3e96ca6 to 1994cbb Compare September 11, 2022 10:42
nikitamikhaylov
nikitamikhaylov reviewed Sep 20, 2022
View reviewed changes
@InfJoker InfJoker force-pushed the ssh-plain-authentication branch 2 times, most recently from f248177 to 16d7fa6 Compare September 27, 2022 22:03
@alexey-milovidov alexey-milovidov mentioned this pull request Oct 8, 2022
Closed
@InfJoker InfJoker force-pushed the ssh-plain-authentication branch from 16d7fa6 to 96b7d86 Compare October 13, 2022 13:32
@InfJoker InfJoker force-pushed the ssh-plain-authentication branch from 96b7d86 to 91b1ce8 Compare October 13, 2022 14:05
@InfJoker InfJoker changed the title [WIP] Ssh keys authentication Ssh keys authentication Oct 13, 2022
@InfJoker
Copy link
Copy Markdown
Contributor Author

InfJoker commented Aug 29, 2023

@InfJoker Another question - would you mind if I just copy the internals of SSHPublicKey.h/.cpp from your PR? So the commit will be actually associated with my account. I've already stolen some cmake-related files, but better to ask later than never.

Sure, feel free to do it

@nikitamikhaylov nikitamikhaylov force-pushed the ssh-plain-authentication branch from 4179e3c to b4749e3 Compare September 5, 2023 15:37
@nikitamikhaylov nikitamikhaylov changed the title Ssh keys authentication SSH keys authentication Sep 26, 2023
@nikitamikhaylov nikitamikhaylov merged commit 0ce30ab into ClickHouse:master Sep 26, 2023
@ernado ernado mentioned this pull request Nov 8, 2023
Closed
@rschu1ze rschu1ze mentioned this pull request Jan 25, 2024
Merged
rschu1ze
rschu1ze reviewed Feb 5, 2024
View reviewed changes
contrib/libssh-cmake/CMakeLists.txt
if (OS_LINUX)
if (ARCH_AMD64)
if (USE_MUSL)
target_include_directories(_ssh PRIVATE "${ClickHouse_SOURCE_DIR}/contrib/libssh-cmake/linux/x86-64-musl")
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were these files generated (e.g. which make/cmake options)? Someone is trying to upgrade libssl from v0.97 to v0.98 and the architecture files need to be re-generated. There is a chance that things will continue to work without regeneration but it will be nicer to have the steps documented somewhere.

Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on config.h.cmake and this command you have to generate them by configuring libssh using the built in cmake.

@rschu1ze rschu1ze mentioned this pull request Feb 7, 2024
Merged
@rschu1ze rschu1ze mentioned this pull request Apr 4, 2024
Merged
30 tasks
@shivanshuraj1333 shivanshuraj1333 mentioned this pull request Jul 14, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin left review comments

@rschu1ze rschu1ze rschu1ze left review comments

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

No one assigned

Labels

can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@InfJoker @CLAassistant @robot-ch-test-poll1 @nikitamikhaylov @antaljanosbenjamin @rschu1ze @alexey-milovidov @robot-clickhouse @robot-ch-test-poll @robot-clickhouse-ci-1