Fix failed stress test (OpenTelemetry)#41050
Merged
rschu1ze merged 3 commits intoClickHouse:masterfrom Sep 8, 2022
Merged
Conversation
Signed-off-by: Frank Chen <[email protected]>
robot-ch-test-poll2
added
the
pr-not-for-changelog
rschu1ze
reviewed
Sep 6, 2022
Signed-off-by: Frank Chen <[email protected]>
Signed-off-by: Frank Chen <[email protected]>
rschu1ze
approved these changes
Sep 7, 2022
rschu1ze
changed the title
rschu1ze
removed
the
pr-not-for-changelog
robot-ch-test-poll1
added
the
pr-not-for-changelog
antonio2368
added
the
can be tested
rschu1ze
approved these changes
Sep 7, 2022
Merged
Contributor
Author
|
There's a test in I didn't find any error messages related to the opentelemetry in the clickhouse-server.err.log. |
Member
I agree --> merging. |
Member
Actually it fails because of, likely, server was too slow to respond to the ping queries from |
Member
|
Stateless tests (ubsan) - actually it's #40410 |
Contributor
Author
|
Good to hear that, thank you for your information @tavplubix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stress test problem mentioned at: #39010 (comment)
The solution is to move
addAttributecall from ctor to dtor so that both ctor and dtor are exception safe.cc @rschu1ze @tavplubix @qoega
Changelog category (leave one):