Skip to content

Fix logical error from write-though cache from stress test#40759

Merged
kssenii merged 2 commits intoClickHouse:masterfrom
kssenii:fix-write-through-cache-logical-error
Aug 31, 2022
Merged

Fix logical error from write-though cache from stress test#40759
kssenii merged 2 commits intoClickHouse:masterfrom
kssenii:fix-write-through-cache-logical-error

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Aug 29, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix logical error in write-through cache "File segment completion can be done only by downloader". Closes #40748.

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Aug 29, 2022
@vdimir vdimir self-assigned this Aug 30, 2022
vdimir
vdimir approved these changes Aug 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is it tricky to reproduce the failure in tests?

@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Aug 30, 2022

Is it tricky to reproduce the failure in tests?

Yes.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Aug 30, 2022

Not so tricky:
https://s3.amazonaws.com/clickhouse-test-reports/36837/e0fab1fa118814f1a83b9bac79135a191441fa88/stress_test__address_.html
https://s3.amazonaws.com/clickhouse-test-reports/36837/e0fab1fa118814f1a83b9bac79135a191441fa88/stress_test__debug_.html
https://s3.amazonaws.com/clickhouse-test-reports/36837/e0fab1fa118814f1a83b9bac79135a191441fa88/stress_test__memory_.html
https://s3.amazonaws.com/clickhouse-test-reports/36837/e0fab1fa118814f1a83b9bac79135a191441fa88/stress_test__thread_.html
https://s3.amazonaws.com/clickhouse-test-reports/36837/e0fab1fa118814f1a83b9bac79135a191441fa88/stress_test__undefined_.html

@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Aug 30, 2022

I meant tricky to make a stateless test which will at once reproduce without stress test.

@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Aug 31, 2022

Stateless tests (memory) [3/3] — Tests are not finished, fail: 3

Annoy

Saved preprocessed configuration to '/var/lib/clickhouse/preprocessed_configs/users.xml'.
==640==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x44d20d3d in void Annoy::(anonymous namespace)::two_means<float, Annoy::Kiss64Random, Annoy::Euclidean, Annoy::Minkowski::Node<unsigned long, float> >(std::__1::vector<Annoy::Minkowski::Node<unsigned long, float>*, std::__1::allocator<Annoy::Minkowski::Node<unsigned long, float>*> > const&, int, Annoy::Kiss64Random&, bool, Annoy::Minkowski::Node<unsigned long, float>*, Annoy::Minkowski::Node<unsigned long, float>*) build_docker/../contrib/annoy/src/annoylib.h:398:9
    #1 0x44d20d3d in void Annoy::Euclidean::create_split<unsigned long, float, Annoy::Kiss64Random>(std::__1::vector<Annoy::Minkowski::Node<unsigned long, float>*, std::__1::allocator<Annoy::Minkowski::Node<unsigned long, float>*> > const&, int, unsigned long, Annoy::Kiss64Random&, Annoy::Minkowski::Node<unsigned long, float>*) build_docker/../contrib/annoy/src/annoylib.h:773:5

@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Aug 31, 2022

In last commit several checks are not finished and are not restarted, but last commit was just a merge with master + previous commit all checks are ok. So I will merge.

@kssenii kssenii merged commit 9abcfce into ClickHouse:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: File segment completion can be done only by downloader

4 participants

@kssenii @alesapin @vdimir @robot-ch-test-poll