Fix LOGICAL_ERROR with max_read_buffer_size=0 during reading marks#40705
Merged
kssenii merged 1 commit intoClickHouse:masterfrom Aug 28, 2022
Merged
Fix LOGICAL_ERROR with max_read_buffer_size=0 during reading marks#40705kssenii merged 1 commit intoClickHouse:masterfrom
kssenii merged 1 commit intoClickHouse:masterfrom
Conversation
The problem is that the buffer size validated after marks reading in MergeTreeReaderStream::init(), since it requires to read marks first. And later it is passed to AsynchronousReadBufferFromFileDescriptor, which throws LOGICAL_ERROR because buffer_size < alignment. Fix this my simply disallow such values for max_read_buffer_size (I thougt about modifying createReadBufferFromFileBase(), but it is not used for remote reads -- remote_fs_buffer_size). Fixes: ClickHouse#40669 Signed-off-by: Azat Khuzhin <[email protected]>
robot-ch-test-poll
added
the
pr-bugfix
Member
Author
Real OOM |
kssenii
approved these changes
Aug 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix LOGICAL_ERROR with max_read_buffer_size=0 during reading marks
The problem is that the buffer size validated after marks reading in
MergeTreeReaderStream::init(), since it requires to read marks first.
And later it is passed to AsynchronousReadBufferFromFileDescriptor,
which throws LOGICAL_ERROR because buffer_size < alignment.
Fix this my simply disallow such values for max_read_buffer_size (I
thougt about modifying createReadBufferFromFileBase(), but it is not
used for remote reads -- remote_fs_buffer_size).
Fixes: #40669 (cc @davenger )