Add llvm-15 for llvm-symbolizer-15 for clang-15 (used for TSan)#40655
Merged
tavplubix merged 1 commit intoClickHouse:masterfrom Aug 26, 2022
Merged
Add llvm-15 for llvm-symbolizer-15 for clang-15 (used for TSan)#40655tavplubix merged 1 commit intoClickHouse:masterfrom
tavplubix merged 1 commit intoClickHouse:masterfrom
Conversation
Simply installing llvm-15 over TSAN_SYMBOLIZER_PATH had been prefered (to keep everything in one place and as simple as possible), though TSAN_SYMBOLIZER_PATH should also work. Signed-off-by: Azat Khuzhin <[email protected]>
robot-ch-test-poll
added
the
pr-not-for-changelog
tavplubix
approved these changes
Aug 26, 2022
Member
|
AST fuzzer (debug) - #40659 |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Sep 4, 2022
Simply installing llvm-symbolizer-$VER is not enough, since it does not contain proper symblink, while LLVM is looking only for "llvm-symbolizer" (without version) - [1]: [1]: https://github.com/llvm/llvm-project/blob/c444af1c20b35555f2fdb2c1ca38d3f23b2faebd/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp#L454 Follow-up for: ClickHouse#40655 Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply installing llvm-15 over TSAN_SYMBOLIZER_PATH had been prefered
(to keep everything in one place and as simple as possible), though
TSAN_SYMBOLIZER_PATH should also work.
Changelog category (leave one):