Remove wrong code for skipping mutations in MergeTree#40589
Merged
Remove wrong code for skipping mutations in MergeTree#40589
Conversation
robot-ch-test-poll1
added
the
pr-bugfix
Member
Author
|
Stateless tests (thread) [3/3] - #40660 |
quickhouse
reviewed
Sep 1, 2022
| has_mutations = !current_mutations_by_version.empty(); | ||
| } | ||
|
|
||
| if ((!mutate_entry && has_mutations) || were_some_mutations_skipped) |
Contributor
There was a problem hiding this comment.
This was probably wrong thing.
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 19, 2022
robot-clickhouse
added
the
pr-backports-created
tavplubix
added a commit
that referenced
this pull request
Oct 20, 2022
Backport #40589 to 22.8: Remove wrong code for skipping mutations in MergeTree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Removed skipping of mutations in unaffected partitions of
MergeTreetables, because this feature never worked correctly and might cause resurrection of finished mutations.Initially introduced in #21326, but there's no way it could work correctly. It's not clear how to fix it, so let's just remove.
cc: @excitoon