Fix possible race in fs cache#40586
Merged
kssenii merged 8 commits intoClickHouse:masterfrom Aug 30, 2022
Merged
Conversation
robot-ch-test-poll2
added
the
pr-bugfix
alesapin
reviewed
Aug 28, 2022
alesapin
approved these changes
Aug 30, 2022
| std::lock_guard cache_lock(cache->mutex); | ||
|
|
||
| size_to_reserve = size_to_reserve - already_reserved_size; | ||
| reserved = cache->tryReserve(key(), offset(), size_to_reserve, cache_lock); |
Member
There was a problem hiding this comment.
As far as I see the main fix is here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible race in filesystem cache.