Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
Member
Author
|
Wow, it's green! @nickitat let's merge ASAP. |
alexey-milovidov
added
the
pr-must-backport
nickitat
approved these changes
Sep 12, 2022
This was referenced Sep 12, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 12, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 12, 2022
nickitat
pushed a commit
that referenced
this pull request
Sep 13, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 13, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 13, 2022
robot-clickhouse
added
the
pr-backports-created
nickitat
pushed a commit
that referenced
this pull request
Sep 15, 2022
Co-authored-by: robot-clickhouse <[email protected]>
nickitat
pushed a commit
that referenced
this pull request
Sep 15, 2022
Co-authored-by: robot-clickhouse <[email protected]>
alexey-milovidov
added a commit
that referenced
this pull request
Sep 18, 2022
Backport #40195 to 22.6: Remove strange code
Contributor
Unfortunately that's not true. see #51541 |
Member
Author
|
We should not allow any incorrect (buggy, unsafe) code in our codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix memory safety issues with functions
encryptandcontingencyif Array of Nullable is used as an argument. This fixes #41004.Remove incorrect code introduced in #12550.
The code was incorrect because the value of
getDataAtfor the consecutive array elements should point to consecutive memory locations to enable the implementation ofgetDataAtforColumnArrayof simple values.Note that the attempt to fix it in #40168 was also incorrect because the values of
getDataAtshould be different for empty strings and NULLs.This error does not lead to any user-visible issues.
This partially reverts #12550.
This fixes #41004.