tests: fix 00926_adaptive_index_granularity_pk/00489_pk_subexpression flakiness#40075
Merged
rschu1ze merged 1 commit intoClickHouse:masterfrom Aug 11, 2022
Merged
tests: fix 00926_adaptive_index_granularity_pk/00489_pk_subexpression flakiness#40075rschu1ze merged 1 commit intoClickHouse:masterfrom
rschu1ze merged 1 commit intoClickHouse:masterfrom
Conversation
… flakiness It is possible for toStartOfMinute() to give different result for 0 and 59, for partial timezones (timezone that does not starts from 00:00, like Africa/Monrovia). Before ClickHouse#36656 it fails for another reason, because of overflows [1], but now it fails because it simply return different minutes. [1]: ClickHouse#29953 (comment) Simply pin the UTC there. Fixes: ClickHouse#37786 Signed-off-by: Azat Khuzhin <[email protected]>
robot-ch-test-poll
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Aug 11, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for toStartOfMinute() to give different result for 0 and
59, for partial timezones (timezone that does not starts from 00:00,
like Africa/Monrovia).
Before #36656 it fails for another reason, because of overflows 1, but
now it fails because it simply return different minutes.
Simply pin the UTC there.
Fixes: #37786 (cc @tavplubix )
Changelog category (leave one):