Conversation
…ss store"" This reverts commit 5524706.
robot-clickhouse
added
the
pr-performance
rschu1ze
force-pushed
the
reenable-avx512-vbmi-columnvector-filter
branch
from
d996662 to
8a7df6f
Compare
Member
Author
|
Test failures are unrelated. |
rschu1ze
changed the title
nickitat
reviewed
Aug 15, 2022
nickitat
approved these changes
Aug 15, 2022
alexey-milovidov
added a commit
that referenced
this pull request
Sep 26, 2022
Revert of "Revert the revert of "ColumnVector: optimize filter with AVX512 VBMI2 compress store" #40033"
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 26, 2022
…r: optimize filter with AVX512 VBMI2 compress store" #40033"
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 26, 2022
…r: optimize filter with AVX512 VBMI2 compress store" #40033"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables #39633 after issue #39895 has been detected and the PR was reverted (#39963). It contains the revert's revert plus a fix for issue #39895.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
For systems with AVX512 VBMI2, this PR improves performance by ca. 6% for SSB benchmark queries queries 3.1, 3.2 and 3.3 (SF=100). Tested on Intel Icelake Xeon 8380 * 2 socket.
Courtesy to @guowangy