Add join_overwrite settings for StorageJoin.#3973
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Jan 23, 2019
Merged
Add join_overwrite settings for StorageJoin.#3973alexey-milovidov merged 4 commits intoClickHouse:masterfrom
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Conversation
amosbird
force-pushed
the
join_overwrite
branch
4 times, most recently
from
23eaf64 to
d4e2fd2
Compare
Member
|
Some tests have failed. |
amosbird
force-pushed
the
join_overwrite
branch
from
d4e2fd2 to
6b95dfe
Compare
Collaborator
Author
|
fixed along with some comments. The style errors don't look accurate to me. |
amosbird
force-pushed
the
join_overwrite
branch
3 times, most recently
from
11f24ad to
fe60fc8
Compare
This makes using StorageJoin as dictionary more flexible.
amosbird
force-pushed
the
join_overwrite
branch
from
fe60fc8 to
8ea4d79
Compare
| namespace | ||
| { | ||
| template <ASTTableJoin::Kind KIND, ASTTableJoin::Strictness STRICTNESS, typename Map> | ||
| template <bool pad_left, ASTTableJoin::Strictness STRICTNESS, typename Map> |
Member
There was a problem hiding this comment.
Why the template parameter is named pad_left?
Member
There was a problem hiding this comment.
I can understand, but It can be easily confused with PODArray padding.
Member
There was a problem hiding this comment.
fill_left will be more obvious.
| M(SettingUInt64, max_rows_in_join, 0, "Maximum size of the hash table for JOIN (in number of rows).") \ | ||
| M(SettingUInt64, max_bytes_in_join, 0, "Maximum size of the hash table for JOIN (in number of bytes in memory).") \ | ||
| M(SettingOverflowMode<false>, join_overflow_mode, OverflowMode::THROW, "What to do when the limit is exceeded.") \ | ||
| M(SettingBool, join_overwrite, false, "Whether to overwrite existing values when encountering the same key again.") \ |
Member
There was a problem hiding this comment.
Let's name it as any_join_take_last_row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes using StorageJoin as dictionary more flexible.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
StorageJoin now supports
join_overwritesetting that allows overwriting existing values of the same key.Category (leave one):