free compression and decompression contexts#39578
Merged
alexey-milovidov merged 1 commit intomasterfrom Jul 26, 2022
Merged
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
nickitat
reviewed
Jul 25, 2022
| if (ZSTD_isError(check_result)) | ||
| { | ||
| std::cerr << "Error (ZSTD): " << check_result << " " << ZSTD_getErrorName(check_result) << std::endl; | ||
| ZSTD_freeCCtx(cctx); |
Member
There was a problem hiding this comment.
maybe we can create a RAII guard?
Member
Author
There was a problem hiding this comment.
we keep it kind of C-ish :)
Member
|
sorry, I didn't notice that it is draft |
Member
Author
|
I'll make it ready to merge after build |
Member
|
LGTM. I've already forgotten the reason why it is written in "not quite C++" (the worst programming language). |
Member
|
@yakov-olkhovskiy FYI I've checked the links in the Build Check and the binary size is still over 2 GB. |
Member
Author
|
@alexey-milovidov now we need to replace deployed binaries - it's not replaced on build but rather creates compressed version in programs/self-extracting directory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes memory leaks in compressor and decompressor.
Closes #39572