Skip to content

prewhere action should preserve sorting columns#39157

Merged
KochetovNicolai merged 6 commits intomasterfrom
bug-lost-column
Jul 15, 2022
Merged

prewhere action should preserve sorting columns#39157
KochetovNicolai merged 6 commits intomasterfrom
bug-lost-column

Conversation

@yakov-olkhovskiy
Copy link
Copy Markdown
Member

@yakov-olkhovskiy yakov-olkhovskiy commented Jul 13, 2022 •
edited by KochetovNicolai
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed error Not found column Type in block in selects with PREWHERE and read-in-order optimizations.

closes #37381
closes #36043

@yakov-olkhovskiy yakov-olkhovskiy added the can be tested Allows running workflows for external contributors label Jul 13, 2022
@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Jul 13, 2022
@yakov-olkhovskiy yakov-olkhovskiy marked this pull request as ready for review July 13, 2022 23:40
@orloffv
Copy link
Copy Markdown
Contributor

orloffv commented Jul 14, 2022

can you backport this pr to old stable releases?

@KochetovNicolai KochetovNicolai self-assigned this Jul 14, 2022
@KochetovNicolai
Copy link
Copy Markdown
Member

KochetovNicolai commented Jul 14, 2022

@orloffv definitely

@KochetovNicolai KochetovNicolai added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jul 14, 2022
@KochetovNicolai KochetovNicolai merged commit f6a82a6 into master Jul 15, 2022
@KochetovNicolai KochetovNicolai deleted the bug-lost-column branch July 15, 2022 14:37
This was referenced Jul 15, 2022
Merged
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Jul 15, 2022
Backport #39157 to 22.4: prewhere action should preserve sorting columns
9367eb1
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 15, 2022
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 15, 2022
Merged
robot-clickhouse pushed a commit that referenced this pull request Jul 15, 2022
Backport #39157 to 22.5: prewhere action should preserve sorting columns
a993a17
robot-clickhouse pushed a commit that referenced this pull request Jul 15, 2022
Backport #39157 to 22.6: prewhere action should preserve sorting columns
4e345bf
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 15, 2022
Merged
KochetovNicolai added a commit that referenced this pull request Jul 19, 2022
@KochetovNicolai
Merge pull request #39273 from ClickHouse/backport/22.4/39157
72f4f90 
Backport #39157 to 22.4: prewhere action should preserve sorting columns
KochetovNicolai added a commit that referenced this pull request Jul 19, 2022
@KochetovNicolai
Merge pull request #39274 from ClickHouse/backport/22.5/39157
d8a5fea 
Backport #39157 to 22.5: prewhere action should preserve sorting columns
KochetovNicolai added a commit that referenced this pull request Jul 19, 2022
@KochetovNicolai
Merge pull request #39275 from ClickHouse/backport/22.6/39157
037b40d 
Backport #39157 to 22.6: prewhere action should preserve sorting columns
robot-clickhouse pushed a commit that referenced this pull request Jul 19, 2022
Backport #39157 to 21.8: prewhere action should preserve sorting columns
4cedf3e
This was referenced Jul 19, 2022
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Jul 19, 2022
Backport #39157 to 22.3: prewhere action should preserve sorting columns
fb047e2
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 19, 2022
KochetovNicolai added a commit that referenced this pull request Aug 1, 2022
@KochetovNicolai
Merge pull request #39381 from ClickHouse/backport/22.3/39157
ae0dc18 
Backport #39157 to 22.3: prewhere action should preserve sorting columns
KochetovNicolai added a commit that referenced this pull request Aug 1, 2022
@KochetovNicolai
Merge pull request #39380 from ClickHouse/backport/21.8/39157
5dfeb98 
Backport #39157 to 21.8: prewhere action should preserve sorting columns
KochetovNicolai added a commit that referenced this pull request Nov 3, 2022
@KochetovNicolai
Try to fix #39157 in a different way.
0360874
KochetovNicolai added a commit that referenced this pull request Nov 3, 2022
@KochetovNicolai
Try to fix #39157 in a different way.
51ec95e
@KochetovNicolai KochetovNicolai mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KochetovNicolai KochetovNicolai

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception with optimize_move_to_prewhere = 1 Not found column in block exception

4 participants

@yakov-olkhovskiy @orloffv @KochetovNicolai @robot-ch-test-poll