Avoid printing SETTINGS twice when formatting a query#38900
Merged
rschu1ze merged 7 commits intoClickHouse:masterfrom Aug 23, 2022
Merged
Avoid printing SETTINGS twice when formatting a query#38900rschu1ze merged 7 commits intoClickHouse:masterfrom
rschu1ze merged 7 commits intoClickHouse:masterfrom
Conversation
robot-ch-test-poll1
added
the
pr-improvement
Algunenano
changed the title
Member
Author
|
The tests look fine, which to me is kind of unexpected since I was hoping to see more examples of the old behaviour since I've been wondering about it for a lot of time. Anyhow, I think this is a positive change in behaviour but it's open to discussion. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rschu1ze
reviewed
Aug 15, 2022
rschu1ze
approved these changes
Aug 22, 2022
Member
|
Test failures are unrelated --> merging. |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Feb 21, 2025
Introduced in ClickHouse#38900, removed in ClickHouse#60197 (ClickHouse#68614)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Don't print
SETTINGSmore than once during query formatting if it didn't appear multiple times in the original query.Closes #38895