ISSUES-3885 temporarily disable predicate optimization for order by#3890
Merged
alexey-milovidov merged 6 commits intoClickHouse:masterfrom Feb 3, 2019
Merged
ISSUES-3885 temporarily disable predicate optimization for order by#3890alexey-milovidov merged 6 commits intoClickHouse:masterfrom
alexey-milovidov merged 6 commits intoClickHouse:masterfrom
Conversation
Contributor
Author
|
Maybe we should tag these functions in the function interface? CREATE TABLE order_view AS SELECT * FROM table_xxx ORDER BY create_time;
SELECT * FROM order_view WHERE name = 'XXX' AND create_time = 'XXX';In this case, optimization makes sense. |
Member
|
Yes, we should mark them as |
Contributor
Author
|
Ok, I'll try to mark them. |
16 tasks
zhang2014
force-pushed
the
fix/ISSUES-3885
branch
from
d5b3c1a to
ddbd384
Compare
Contributor
Author
|
The failure test was fixed in a40f8f9 |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3885
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category:
Short description (up to few sentences):
temporarily disable predicate optimization for order by
Detailed description (optional):
Because the result of some function depend on the order of data, predicates are not optimized when
ORDER BYexists in a subquery.