Skip to content

Use native Map type for OpenTelemetry attributes#38814

Merged
qoega merged 6 commits intoClickHouse:masterfrom
qoega:otel-debug
Jul 6, 2022
Merged

Use native Map type for OpenTelemetry attributes#38814
qoega merged 6 commits intoClickHouse:masterfrom
qoega:otel-debug

Conversation

@qoega
Copy link
Copy Markdown
Member

@qoega qoega commented Jul 4, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 4, 2022
@novikd novikd self-assigned this Jul 4, 2022
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some expressions were accidentally converted to string literals.

@qoega qoega marked this pull request as draft July 5, 2022 10:59
@qoega qoega marked this pull request as ready for review July 6, 2022 12:33
@qoega qoega merged commit 1863fb8 into ClickHouse:master Jul 6, 2022
tavplubix added a commit that referenced this pull request Jul 7, 2022
This reverts commit 1863fb8, reversing
changes made to d276d9e.
tavplubix added a commit that referenced this pull request Jul 11, 2022
Backport #38814 to 22.6: Use native Map type for OpenTelemetry attributes
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants