Skip to content

Fixed parallel writes for S3 does not work#38792

Merged
kssenii merged 4 commits intoClickHouse:masterfrom
xiedeyantu:fix-support-parallel-write
Jul 9, 2022
Merged

Fixed parallel writes for S3 does not work#38792
kssenii merged 4 commits intoClickHouse:masterfrom
xiedeyantu:fix-support-parallel-write

Conversation

@xiedeyantu
Copy link
Copy Markdown
Contributor

@xiedeyantu xiedeyantu commented Jul 4, 2022 •
edited by kssenii
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix checking whether s3 storage support parallel writes. It resulted in s3 parallel writes not working.

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Jul 4, 2022
@kssenii kssenii self-assigned this Jul 4, 2022
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Jul 4, 2022
@kssenii kssenii mentioned this pull request Jul 4, 2022
Merged
@kssenii
Copy link
Copy Markdown
Member

kssenii commented Jul 4, 2022

02228_merge_tree_insert_memory_usage

Possibly related test failure, let's rerun the tests

@kssenii
Copy link
Copy Markdown
Member

kssenii commented Jul 4, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 4, 2022

update

✅ Branch has been successfully updated

@azat
Copy link
Copy Markdown
Member

azat commented Jul 5, 2022

@xiedeyantu can you please write changelog entry in user terms? i.e. what changed for the user (AFAIU previously parallel writes for S3 does not work).

@xiedeyantu
Copy link
Copy Markdown
Contributor Author

xiedeyantu commented Jul 5, 2022

@xiedeyantu can you please write changelog entry in user terms? i.e. what changed for the user (AFAIU previously parallel writes for S3 does not work).

ok, I will finish it.

@xiedeyantu xiedeyantu changed the title add supportParallelWrite() in DiskDecorator Fixed parallel writes for S3 does not work Jul 5, 2022
@kssenii
Copy link
Copy Markdown
Member

kssenii commented Jul 9, 2022

Integration tests

>           fd_event_list = self._selector.poll(timeout)
E           Failed: Timeout >900.0s

/usr/lib/python3.8/selectors.py:415: Failed

@kssenii kssenii merged commit 3eb8c7f into ClickHouse:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kssenii kssenii

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiedeyantu @kssenii @azat @robot-ch-test-poll