tests: make aggregate_state_exception_memory_leak deterministic#38754
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Jul 9, 2022
Merged
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
azat
force-pushed
the
tests-aggregate_state_exception_memory_leak-fix
branch
from
7b0aac0 to
51f60f5
Compare
Member
|
But the whole point of this test was to check for a memory leak by triggering OOM by running the query in a loop, and specifically the case when it throws an exception. |
…istic Sometimes if the 30 seconds is not enough for the query to fail (i.e. under TSan [1]), the error will be ignored and the test will fail. [1]: https://s3.amazonaws.com/clickhouse-test-reports/38748/d863f6ce1ece810c66ddf8bd89575825d3f2595f/stateless_tests__thread__actions__%5B2/3%5D.html Follow-up for: ClickHouse#11496 (cc @alexey-milovidov) Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
tests-aggregate_state_exception_memory_leak-fix
branch
from
51f60f5 to
d1d717d
Compare
Member
Author
I see, thanks. Fixed the patch. |
Member
Author
alexey-milovidov
approved these changes
Jul 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Sometimes if the 30 seconds is not enough for the query to fail (i.e. under TSan),
the error will be ignored and the test will fail.
Drop that loops away, since the query fails everytime and convert it to simple
.sqltest.Follow-up for: #11496 (cc @alexey-milovidov )