Add exp_internal for expect tests#38728
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Jul 2, 2022
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Jul 2, 2022
This is to catch possible issues like 01565_reconnect_after_client_error in [1]. [1]: https://s3.amazonaws.com/clickhouse-test-reports/38417/e33f236d502fe9f7906392f4ceffaee44e3c4ce4/stateless_tests__thread__actions__[3/3].html Signed-off-by: Azat Khuzhin <[email protected]>
azat
commented
Jul 2, 2022
tests/clickhouse-test
Outdated
Member
Author
There was a problem hiding this comment.
Great, CI founds that file_suffix was not used in *.expect - https://s3.amazonaws.com/clickhouse-test-reports/38728/fdebae1f72849f8896b11a35f68953f48abc3e00/stateless_tests_flaky_check__address__actions_.html
Rebased and fixed (now the file will be in CLICKHOUSE_TMP)
Member
Author
You've merged too early. I'm looking. |
Member
Author
|
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Nov 30, 2022
…lete This will help to debug ClickHouse#43809 Follow-up for: ClickHouse#38728 Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Now, if the
.expecttest will fail, it'sexp_internaloutput will be printed byclickhouse-test.This is to catch possible issues like 01565_reconnect_after_client_error in 1 (cc @alexey-milovidov ).