Conversation
Member
|
Consider adding it here: ClickHouse/docker/test/stress/stress Line 11 in e307a72 |
robot-ch-test-poll2
added
the
pr-improvement
CurtizJ
reviewed
Jul 7, 2022
Comment on lines
+20
to
+21
| intermediate_header = getOutputPort().getHeader(); | ||
| intermediate_header.erase(0); |
Member
There was a problem hiding this comment.
Please, explain why first column is removed.
Member
Author
There was a problem hiding this comment.
First column is __grouping_set. It's added exactly before returning generated chunk. intermediate_heade is used to correctly create columns with defaults for input blocks (they don't have __grouping_set column).
tavplubix
reviewed
Jul 7, 2022
Member
|
Stress test failures are related: SELECT
CounterID AS k,
quantileBFloat16(0.5)(ResolutionWidth)
FROM remote('127.0.0.{1,2}', default, hits)
GROUP BY k
ORDER BY
count() DESC,
CounterID ASC
LIMIT 10
SETTINGS group_by_use_nulls = 1
Query id: 3efcd4cf-74fc-4e78-b39b-94d1227953c7
→ Progress: 8.87 million rows, 53.24 MB (83.89 million rows/s., 503.35 MB/s.) 99%
0 rows in set. Elapsed: 0.190 sec. Processed 8.87 million rows, 53.24 MB (46.81 million rows/s., 280.85 MB/s.)
Received exception from server (version 22.7.1):
Code: 49. DB::Exception: Received from localhost:9000. DB::Exception: Bad cast from type DB::ColumnNullable to DB::ColumnVector<unsigned int>. (LOGICAL_ERROR)Failure with WindowView is probably related too. |
CurtizJ
approved these changes
Jul 13, 2022
Member
Author
Seems unrelated |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add
group_by_use_nullssetting to make aggregation key columns nullable in the case of ROLLUP, CUBE and GROUPING SETS. Closes #37359