tests: fix log_comment (extra quotes)#37932
Merged
alesapin merged 1 commit intoClickHouse:masterfrom Jun 21, 2022
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
Member
Author
|
@alesapin why you marked this as draft? |
Signed-off-by: Azat Khuzhin <[email protected]> Cherry-pick: 9a297ce
azat
force-pushed
the
tests-fix-log_comment
branch
from
281150c to
d85421c
Compare
Member
Author
|
Ok, I see, 01175_distributed_ddl_output_mode_long fails, fixed. |
Member
Author
|
@alesapin can you take a look? (this is pretty simple patch) |
alesapin
approved these changes
Jun 21, 2022
Member
|
Msan fixed in #38117 |
Member
|
Tidy and stress look unrelated |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jul 31, 2022
The original issue was that log_comment was wrong, and this test relies on correct log_comment, but this had been fixed already in ClickHouse#37932. Also adjust the timeout to avoid possible query hung check failures. Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick: 9a297ce
Changelog category (leave one):