Fix refcnt for unused MergeTree parts in SELECT queries#37913
Merged
CurtizJ merged 1 commit intoClickHouse:masterfrom Jun 21, 2022
Merged
Fix refcnt for unused MergeTree parts in SELECT queries#37913CurtizJ merged 1 commit intoClickHouse:masterfrom
CurtizJ merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
Before this patch SELECT queries hold parts even if they were not required by select (had been eliminated by partition pruning). This defers removing parts if you have long running queries. This had been introduced in ClickHouse#23932, with introduction of StorageSnapshotPtr. Signed-off-by: Azat Khuzhin <[email protected]>
Member
Author
From Will take a look later. |
CurtizJ
approved these changes
Jun 13, 2022
Member
|
Tests with tsan were failing because of #38019. So, let's merge. |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix refcnt for unused MergeTree parts in SELECT queries (may defer parts removal)
Before this patch SELECT queries hold parts even if they were not
required by select (had been eliminated by partition pruning).
This defers removing parts if you have long running queries.
This had been introduced in #23932, with introduction of
StorageSnapshotPtr.
Cc: @CurtizJ