Skip to content

Update protobuf files for kafka and rabbitmq [fix integration tests]#37884

Merged
alesapin merged 2 commits intoClickHouse:masterfrom
nickitat:update_protobuf_files
Jun 6, 2022
Merged

Update protobuf files for kafka and rabbitmq [fix integration tests]#37884
alesapin merged 2 commits intoClickHouse:masterfrom
nickitat:update_protobuf_files

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Jun 6, 2022 •
edited
Loading

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 6, 2022
@nickitat nickitat force-pushed the update_protobuf_files branch from 508144d to 90f023d Compare June 6, 2022 11:09
@filimonov
Copy link
Copy Markdown
Contributor

filimonov commented Jun 6, 2022 

2022-06-06 12:16:26,087 runner output: test_storage_kafka/test.py:40: in <module>
2022-06-06 12:16:26,087 runner output:     from . import social_pb2
2022-06-06 12:16:26,087 runner output: test_storage_kafka/social_pb2.py:31: in <module>
2022-06-06 12:16:26,087 runner output:     _descriptor.FieldDescriptor(
2022-06-06 12:16:26,087 runner output: /usr/local/lib/python3.8/dist-packages/google/protobuf/descriptor.py:560: in __new__
2022-06-06 12:16:26,087 runner output:     _message.Message._CheckCalledFromGeneratedFile()
2022-06-06 12:16:26,087 runner output: E   TypeError: Descriptors cannot not be created directly.
2022-06-06 12:16:26,087 runner output: E   If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
2022-06-06 12:16:26,087 runner output: E   If you cannot immediately regenerate your protos, some other possible workarounds are:
2022-06-06 12:16:26,087 runner output: E    1. Downgrade the protobuf package to 3.20.x or lower.
2022-06-06 12:16:26,087 runner output: E    2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).
2022-06-06 12:16:26,087 runner output: E
2022-06-06 12:16:26,087 runner output: E   More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

find . -iname '*_pb2.py'
./test_grpc_protocol/_gen/clickhouse_grpc_pb2.py
./test_storage_kafka/social_pb2.py
./test_storage_kafka/message_with_repeated_pb2.py
./test_storage_kafka/kafka_pb2.py
./test_storage_rabbitmq/rabbitmq_pb2.py
./test_grpc_protocol_ssl/_gen/clickhouse_grpc_pb2.py

@alesapin alesapin marked this pull request as ready for review June 6, 2022 18:55
alesapin
alesapin approved these changes Jun 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least they work now.

@alesapin alesapin merged commit 5faaf1b into ClickHouse:master Jun 6, 2022
@qoega
Copy link
Copy Markdown
Member

qoega commented Jun 7, 2022

It would be nice to regenerate them with runner image build or something like it.

This was referenced Jun 15, 2022
Merged
Merged
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 15, 2022
Merged
robot-clickhouse pushed a commit that referenced this pull request Jun 15, 2022
Backport #37884 to 22.3: Update protobuf files for kafka and rabbitmq…
89fdfe3 
… [fix integration tests]
robot-clickhouse pushed a commit that referenced this pull request Jun 15, 2022
Backport #37884 to 22.4: Update protobuf files for kafka and rabbitmq…
abf415c 
… [fix integration tests]
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 15, 2022
Merged
robot-clickhouse pushed a commit that referenced this pull request Jun 15, 2022
Backport #37884 to 22.5: Update protobuf files for kafka and rabbitmq…
b58c77d 
… [fix integration tests]
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 15, 2022
Merged
Felixoid added a commit that referenced this pull request Jun 15, 2022
@Felixoid
Merge pull request #38111 from ClickHouse/backport/22.3/37884
7a0266d 
Backport #37884 to 22.3: Update protobuf files for kafka and rabbitmq [fix integration tests]
Felixoid added a commit that referenced this pull request Jun 15, 2022
@Felixoid
Merge pull request #38112 from ClickHouse/backport/22.4/37884
c5662ef 
Backport #37884 to 22.4: Update protobuf files for kafka and rabbitmq [fix integration tests]
tavplubix added a commit that referenced this pull request Jun 17, 2022
@tavplubix
Merge pull request #38113 from ClickHouse/backport/22.5/37884
e89e225 
Backport #37884 to 22.5: Update protobuf files for kafka and rabbitmq [fix integration tests]
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 23, 2022
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 23, 2022
Merged
robot-clickhouse pushed a commit that referenced this pull request Jun 23, 2022
Backport #37884 to 21.8: ('Update protobuf files for kafka and rabbit…
622a567 
…mq [fix integration tests]',)
tavplubix added a commit that referenced this pull request Jun 23, 2022
@tavplubix
Merge pull request #38345 from ClickHouse/backport/21.8/37884
75aa06d 
Backport #37884 to 21.8: ('Update protobuf files for kafka and rabbitmq [fix integration tests]',)
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

Assignees

No one assigned

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nickitat @filimonov @qoega @alesapin @Felixoid @tavplubix @robot-clickhouse