clickhouse-keeper bugfix: dead_session_check_period was passed as micros instead of millis#37824
Merged
nikitamikhaylov merged 2 commits intomasterfrom Jun 3, 2022
Conversation
… micros instead of millis.
robot-clickhouse
added
the
pr-bugfix
antonio2368
added
the
can be tested
alesapin
approved these changes
Jun 3, 2022
antonio2368
approved these changes
Jun 3, 2022
Member
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
nikitamikhaylov
approved these changes
Jun 3, 2022
tavplubix
approved these changes
Jun 3, 2022
kssenii
approved these changes
Jun 3, 2022
davenger
approved these changes
Jun 3, 2022
Member
|
Fast test is Ok, merging |
nikitamikhaylov
deleted the
keeper-dead_session_check_period-ms-instead-of-micros
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The clickhouse-keeper setting
dead_session_check_period_mswas transformed into microseconds (multiplied by 1000), which lead to dead sessions only being cleaned up after several minutes (instead of 500ms).