Initialize ParallelReadBuffer after construction#37726
Merged
antonio2368 merged 3 commits intomasterfrom Jun 2, 2022
Merged
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
devcrafter
reviewed
Jun 1, 2022
rschu1ze
reviewed
Jun 1, 2022
rschu1ze
approved these changes
Jun 1, 2022
antonio2368
commented
Jun 1, 2022
Comment on lines
+52
to
+60
| try | ||
| { | ||
| addReaders(); | ||
| } | ||
| catch (const Exception &) | ||
| { | ||
| finishAndWait(); | ||
| throw; | ||
| } |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Some of the readers can throw exceptions so initializing the
ParallelReadBufferin constructor can lead to undefined state if the exception happens while the readers are being added.cc: @davenger @Avogar