Skip to content

Fix segfault with mysql db + show create table + named collections#37690

Merged
kssenii merged 2 commits intoClickHouse:masterfrom
kssenii:fix-mysql-db
Jun 2, 2022
Merged

Fix segfault with mysql db + show create table + named collections#37690
kssenii merged 2 commits intoClickHouse:masterfrom
kssenii:fix-mysql-db

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented May 31, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix segmentation fault in show create table from mysql database when it is configured with named collections. Closes #37683.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label May 31, 2022
@Avogar Avogar self-assigned this May 31, 2022
@tavplubix
Copy link
Copy Markdown
Member

It makes sense to check other places where named collections can be used.

@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Jun 1, 2022

It makes sense to check other places where named collections can be used.

similar place is in postgres only, there it is fixed

@kssenii kssenii merged commit 2f777b7 into ClickHouse:master Jun 2, 2022
@UnamedRus
Copy link
Copy Markdown
Contributor

It's possible to have backport to 22.3?

@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jun 3, 2022
robot-clickhouse pushed a commit that referenced this pull request Jun 3, 2022
robot-clickhouse pushed a commit that referenced this pull request Jun 3, 2022
robot-clickhouse pushed a commit that referenced this pull request Jun 3, 2022
kssenii added a commit that referenced this pull request Jun 6, 2022
Backport #37690 to 22.3: Fix segfault with mysql db + show create table + named collections
kaynewu added a commit to kaynewu/ClickHouse that referenced this pull request Jun 9, 2022
* Backport ClickHouse#36167 to 22.3: Fix broken aliases during parsing of special operators

* Backport git fix for /build directory

* Trigger CI

* Update version to 22.3.5.20

* Backport ClickHouse#36637 to 22.3: Fix merges of wide parts with type `Object`

* Backport ClickHouse#36487 to 22.3: Add passphrase for certificates

* Backport ClickHouse#36707 to 22.3: Fix vertical merges in wide parts

* Update version to 22.3.6.5

* Backport ClickHouse#36910 to 22.3: Fix bug in keeper which could lead to corrupted compressed logs

* Update version to 22.3.7.5

* Backport ClickHouse#36866 to 22.3: Integration tests

* Backport ClickHouse#35803 to 22.3: Fix bug in indexes of not presented columns in -WithNames formats

* Backport ClickHouse#37021 to 22.3: Fixed problem with infs in `quantileTDigest`

* Backport ClickHouse#36463 to 22.3: Ignore DNS errors when checking if dictionary source is local

* Backport ClickHouse#37443 to 22.3: Functions normalize utf8 fix

* Backport ClickHouse#37336 to 22.3: Fix clash of constant strings in aggregate function, prewhere and join

* Backport ClickHouse#37690 to 22.3: Fix segfault with mysql db + show create table + named collections

Co-authored-by: robot-clickhouse <[email protected]>
Co-authored-by: Mikhail f. Shiryaev <[email protected]>
Co-authored-by: Anton Popov <[email protected]>
Co-authored-by: Maksim Kita <[email protected]>
Co-authored-by: Alexey Milovidov <[email protected]>
Co-authored-by: alesapin <[email protected]>
Co-authored-by: Kruglov Pavel <[email protected]>
Co-authored-by: Alexander Tokmakov <[email protected]>
Co-authored-by: Vladimir C <[email protected]>
Co-authored-by: Kseniia Sumarokova <[email protected]>
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

22.3.6.5 Crash in SHOW CREATE TABLE mysql_engine

6 participants