Proper wait of the clickhouse-server in tests#37560
Merged
tavplubix merged 5 commits intoClickHouse:masterfrom Jun 17, 2022
Merged
Proper wait of the clickhouse-server in tests#37560tavplubix merged 5 commits intoClickHouse:masterfrom
tavplubix merged 5 commits intoClickHouse:masterfrom
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
azat
force-pushed
the
tests-scripts-proper-wait
branch
3 times, most recently
from
9d96a49 to
5fd0010
Compare
If 10 seconds will not be enough to finish the server, then
clickhouse-local (that goes after) cannot obtain the logs due to status
file will be locked, like in [1]:
Code: 76. DB::Exception: Cannot lock file /var/lib/clickhouse/status. Another server instance in same directory is already running. (CANNOT_OPEN_FILE)
[1]: https://s3.amazonaws.com/clickhouse-test-reports/35075/4a064e5b6f81136f2bf923d85001f25fa05d39ce/stateless_tests_flaky_check__address__actions_.html
So use proper wait via "clickhouse stop"
v2: Fix permissions pid file for replicated database servers
They do not use default, /var/run/clickhouse-server, that do not have
proper permissions.
Fixes: ClickHouse#36885
Signed-off-by: Azat Khuzhin <[email protected]>
Signed-off-by: Azat Khuzhin <[email protected]>
v2: fix permissions for /var/run/clickhouse-server? Signed-off-by: Azat Khuzhin <[email protected]>
Signed-off-by: Azat Khuzhin <[email protected]>
Note, thiat removes "ability to run fasttest locally", but other jobs cannot do this. Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
tests-scripts-proper-wait
branch
from
5fd0010 to
827e73a
Compare
Member
Author
|
Can someone take a look please? |
tavplubix
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):