Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
Member
Author
|
Fast test (actions) - |
alesapin
approved these changes
May 23, 2022
| return COMMITTED; | ||
| } | ||
|
|
||
| bool MergeTreeTransaction::waitStateChange(CSN expected_state_csn) const |
Member
There was a problem hiding this comment.
Maybe the argument name confusing me, but in this function, we wait until csn will be not equal to expected_state_csn?
Member
Author
There was a problem hiding this comment.
Right, it means "value that we expect to see when we start waiting"
|
|
||
| Float64 elapsedSeconds() const { return elapsed.elapsedSeconds(); } | ||
|
|
||
| bool waitStateChange(CSN expected_state_csn) const; |
| return Tx::CommittingCSN; | ||
| } | ||
|
|
||
| NOEXCEPT_SCOPE; |
Member
There was a problem hiding this comment.
Add a comment, I cannot guess why exceptions are not allowed here.
Member
Author
|
PullRequestCI / IntegrationTestsTsan2 (pull_request) Failing after 28m — IntegrationTestsTsan2 - Process completed with exit code 137, cc: @Felixoid |
Merged
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 30, 2022
In [1] there was only few transactions, but lots of List for /test/clickhouse/txn/log:
$ clickhouse-local --format TSVWithNamesAndTypes --file zookeeper_log.tsv.gz -q "select * except('path|session_id|event_time|thread_id|event_date|xid') apply(x->groupUniqArray(x)), path, session_id, min(event_time), max(event_time), count() from table where has_watch and type = 'Request' group by path, session_id order by count() desc limit 1 format Vertical"
Row 1:
──────
groupUniqArray(type): ['Request']
groupUniqArray(query_id): ['','62d75128-9031-48a5-87ba-aec3f0b591c6']
groupUniqArray(address): ['::1']
groupUniqArray(port): [9181]
groupUniqArray(has_watch): [1]
groupUniqArray(op_num): ['List']
groupUniqArray(data): ['']
groupUniqArray(is_ephemeral): [0]
groupUniqArray(is_sequential): [0]
groupUniqArray(version): []
groupUniqArray(requests_size): [0]
groupUniqArray(request_idx): [0]
groupUniqArray(error): []
groupUniqArray(watch_type): []
groupUniqArray(watch_state): []
groupUniqArray(stat_version): [0]
groupUniqArray(stat_cversion): [0]
groupUniqArray(stat_dataLength): [0]
groupUniqArray(stat_numChildren): [0]
groupUniqArray(children): [[]]
path: /test/clickhouse/txn/log
session_id: 1
min(event_time): 2022-05-27 12:54:09.025897
max(event_time): 2022-05-27 13:37:12.846314 <!-- last transaction was at 12:54, see server log
count(): 3673675 <-- huge
[1]: https://s3.amazonaws.com/clickhouse-test-reports/37593/2613149f6bf4f242bbbf2c3c8539b5176fd77286/stateless_tests__debug__actions__[1/3].html
Server log:
$ pigz -cd clickhouse-server.log.gz | fgrep TransactionLog: | head -1
2022.05.27 12:54:09.026852 [ 5018 ] {62d75128-9031-48a5-87ba-aec3f0b591c6} <Trace> TransactionLog: Loading 33 entries from /test/clickhouse/txn/log: csn-0000000000..csn-0000000032
$ pigz -cd clickhouse-server.log.gz | fgrep TransactionLog: | tail -1
2022.05.27 12:54:58.909222 [ 509 ] {} <Test> TransactionLog: Closing readonly transaction (177, 38, 41b51ff1-bcba-43bf-bcea-e97ad05f6040)
$ pigz -cd clickhouse-server.log.gz | fgrep 62d75128-9031-48a5-87ba-aec3f0b591c6 | tail -1
2022.05.27 12:54:09.064857 [ 5018 ] {62d75128-9031-48a5-87ba-aec3f0b591c6} <Debug> MemoryTracker: Peak memory usage (for query): 0.00 B.
Fixes: ClickHouse#37398 (cc @tavplubix)
Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes #37133 (trivial bug)
Fixes #37094 by handling connection loss correctly (previously it was just ignored)
Fixes a bug in
removal_tiddeserialization.Adds more hardening to catch even more interesting bugs.