Fix clash of constant strings in aggregate function, prewhere and join#37336
Merged
vdimir merged 3 commits intoClickHouse:masterfrom May 23, 2022
Merged
Fix clash of constant strings in aggregate function, prewhere and join#37336vdimir merged 3 commits intoClickHouse:masterfrom
vdimir merged 3 commits intoClickHouse:masterfrom
Conversation
robot-ch-test-poll
added
the
pr-bugfix
vdimir
force-pushed
the
fix_clash_const_aggegate_join
branch
from
d2f967c to
3399804
Compare
vdimir
commented
May 23, 2022
| NamesAndTypesList result_names_and_types = required_columns; | ||
| analyzed_join->addJoinedColumnsAndCorrectTypes(result_names_and_types, true); | ||
| for (const auto & [name, type] : result_names_and_types) | ||
| /// `column` is `nullptr` because we don't care on constness here, it may be changed in join |
Member
Author
There was a problem hiding this comment.
columnisnullptrbecause we don't care on constness here, it may be changed in join
Maybe that was fixed later in other way (it's good to find what change exactly, but seems tricky), now all test passed without replacing column to nullptr
novikd
approved these changes
May 23, 2022
vdimir
added
the
pr-must-backport
This was referenced May 31, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
May 31, 2022
…unction, prewhere and join
robot-clickhouse
pushed a commit
that referenced
this pull request
May 31, 2022
…unction, prewhere and join
robot-clickhouse
pushed a commit
that referenced
this pull request
May 31, 2022
…unction, prewhere and join
vdimir
added a commit
that referenced
this pull request
Jun 1, 2022
Backport #37336 to 22.4: Fix clash of constant strings in aggregate function, prewhere and join
vdimir
added a commit
that referenced
this pull request
Jun 1, 2022
Backport #37336 to 22.5: Fix clash of constant strings in aggregate function, prewhere and join
kaynewu
added a commit
to kaynewu/ClickHouse
that referenced
this pull request
Jun 9, 2022
* Backport ClickHouse#36167 to 22.3: Fix broken aliases during parsing of special operators * Backport git fix for /build directory * Trigger CI * Update version to 22.3.5.20 * Backport ClickHouse#36637 to 22.3: Fix merges of wide parts with type `Object` * Backport ClickHouse#36487 to 22.3: Add passphrase for certificates * Backport ClickHouse#36707 to 22.3: Fix vertical merges in wide parts * Update version to 22.3.6.5 * Backport ClickHouse#36910 to 22.3: Fix bug in keeper which could lead to corrupted compressed logs * Update version to 22.3.7.5 * Backport ClickHouse#36866 to 22.3: Integration tests * Backport ClickHouse#35803 to 22.3: Fix bug in indexes of not presented columns in -WithNames formats * Backport ClickHouse#37021 to 22.3: Fixed problem with infs in `quantileTDigest` * Backport ClickHouse#36463 to 22.3: Ignore DNS errors when checking if dictionary source is local * Backport ClickHouse#37443 to 22.3: Functions normalize utf8 fix * Backport ClickHouse#37336 to 22.3: Fix clash of constant strings in aggregate function, prewhere and join * Backport ClickHouse#37690 to 22.3: Fix segfault with mysql db + show create table + named collections Co-authored-by: robot-clickhouse <[email protected]> Co-authored-by: Mikhail f. Shiryaev <[email protected]> Co-authored-by: Anton Popov <[email protected]> Co-authored-by: Maksim Kita <[email protected]> Co-authored-by: Alexey Milovidov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Kruglov Pavel <[email protected]> Co-authored-by: Alexander Tokmakov <[email protected]> Co-authored-by: Vladimir C <[email protected]> Co-authored-by: Kseniia Sumarokova <[email protected]>
Felixoid
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix unexpected errors with a clash of constant strings in aggregate function, prewhere and join. Close #36891