Improve OpenTelemetry spans creation after Processors were implemented#37186
Closed
qoega wants to merge 1 commit intoClickHouse:masterfrom
Closed
Improve OpenTelemetry spans creation after Processors were implemented#37186qoega wants to merge 1 commit intoClickHouse:masterfrom
qoega wants to merge 1 commit intoClickHouse:masterfrom
Conversation
Member
Author
vdimir
reviewed
May 13, 2022
| { | ||
| UInt64 elapsed_microseconds = execution_time_watch->elapsedMicroseconds(); | ||
| node->processor->elapsed_us += elapsed_microseconds; | ||
| span.addAttribute("execution_time_ns", elapsed_microseconds); |
Member
There was a problem hiding this comment.
Why execution_time_ns, but elapsed_microseconds ?
Also if bool(profile_processors) == true and NDEBUG attributes would be set twice, it it ok?
f20b5d5 to
1f5ffd7
Compare
vdimir
approved these changes
May 16, 2022
Member
Author
|
I guess I will rework spans order. It is almost unusable with longer queries. I think
Failure in FunctionalStatefulTestTsan is related: |
4f2028f to
f20b5d5
Compare
Member
Author
|
This PR instead #37837 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
OpenTelemetry spans now show active time in Processors.