Skip to content

Some fixes for replicated merge tree#36909

Merged
alexey-milovidov merged 3 commits intomasterfrom
fixes_for_replicated_merge_tree
May 5, 2022
Merged

Some fixes for replicated merge tree#36909
alexey-milovidov merged 3 commits intomasterfrom
fixes_for_replicated_merge_tree

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented May 4, 2022 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #36610, fixes #36849

Also fixes tests failures like this:

2022-05-04 18:28:07 01154_move_partition_long:                                              [ FAIL ] 485.28 sec. - having stderror: 
2022-05-04 18:28:07 [8ede6580e4d7] 2022.05.04 18:28:01.266166 [ 38229 ] {485dc017-068a-4be9-83b2-541761cf8f34} <Error> InterpreterSystemQuery: SYNC REPLICA test_rfl2xt.dst_0 (0c372787-157e-4020-aee9-4f6402054255): Timed out!

2022-05-04 18:28:07 stdout:
2022-05-04 18:28:07 sync failed, queue:	default	dst_0	0	1	queue-0000000519	REPLACE_RANGE	2022-05-04 18:20:59	0	7		[]	0	0	659	Code: 234. DB::Exception: Not found part 6_54_54_0 (or part covering it) neither source table neither remote replicas. (NO_REPLICA_HAS_PART) (version 22.5.1.1)	2022-05-04 18:28:01	51	Not executing log entry queue-0000000519 of type REPLACE_RANGE for part  because another DROP_RANGE or REPLACE_RANGE entry are currently executing.	2022-05-04 18:21:05	
2022-05-04 18:28:07 sync failed, queue:	default	dst_0	0	0	queue-0000000530	DROP_RANGE	2022-05-04 18:21:00	0	2	6_54_54_0	[]	0	0	0		1970-01-01 07:00:00	1806	Not executing log entry queue-0000000530 of type DROP_RANGE for part 6_54_54_0 because another DROP_RANGE or REPLACE_RANGE entry are currently executing.	2022-05-04 18:28:01

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 4, 2022
@tavplubix tavplubix mentioned this pull request May 4, 2022
Merged
@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented May 5, 2022

We should backport it to 22.4

@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label May 5, 2022
@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented May 5, 2022

Wow:

All checks have passed
159 successful checks

@tavplubix tavplubix requested a review from alesapin May 5, 2022 18:58
@alexey-milovidov alexey-milovidov self-assigned this May 5, 2022
@alexey-milovidov alexey-milovidov merged commit 4c6f964 into master May 5, 2022
@alexey-milovidov alexey-milovidov deleted the fixes_for_replicated_merge_tree branch May 5, 2022 21:44
This was referenced May 6, 2022
Closed
Merged
Closed
Closed
robot-clickhouse pushed a commit that referenced this pull request May 6, 2022
Backport #36909 to 22.4: Some fixes for replicated merge tree
f8983f2
@robot-clickhouse robot-clickhouse mentioned this pull request May 6, 2022
Merged
tavplubix added a commit that referenced this pull request May 6, 2022
@tavplubix
Merge pull request #36959 from ClickHouse/backport/22.4/36909
059ef6c 
Backport #36909 to 22.4: Some fixes for replicated merge tree
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@alesapin alesapin Awaiting requested review from alesapin

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: 'Part 9_0_0_0 (state PreActive) not found in data_parts'. Uncaught exception in ActiveDataPartSet::add

4 participants

@tavplubix @alexey-milovidov @Felixoid @robot-ch-test-poll1