Added zookeeper multi-read support#36725
Closed
asokol123 wants to merge 7 commits intoClickHouse:masterfrom
asokol123:asokolovskiy/multi-read
Closed
Added zookeeper multi-read support#36725asokol123 wants to merge 7 commits intoClickHouse:masterfrom asokol123:asokolovskiy/multi-read
asokol123 wants to merge 7 commits intoClickHouse:masterfrom
asokol123:asokolovskiy/multi-read
Conversation
|
|
robot-ch-test-poll1
added
the
pr-not-for-changelog
alexey-milovidov
added
the
can be tested
Member
|
The |
antonio2368
reviewed
May 24, 2022
src/Common/ZooKeeper/TestKeeper.cpp
Outdated
Member
There was a problem hiding this comment.
Use something like
enum class OpKind : uint8_t
{
Read,
Write
};
Code will be easier to read
src/Common/ZooKeeper/TestKeeper.cpp
Outdated
Member
There was a problem hiding this comment.
Suggested change
| response.names = full_response->names; | |
| response.names = std::move(full_response->names); |
src/Common/ZooKeeper/TestKeeper.cpp
Outdated
Member
There was a problem hiding this comment.
Why not instantly make a shared_ptr of SimpleListResponse?
Member
There was a problem hiding this comment.
Suggested change
| enum class OpKind : int32_t | |
| enum class OpKind : uint8_t |
utils/zookeeper-test/main.cpp
Outdated
Member
There was a problem hiding this comment.
Suggested change
| void assert_eq(const T& left, const U& right) | |
| void assert_eq(const T & left, const U & right) |
utils/zookeeper-test/main.cpp
Outdated
Member
There was a problem hiding this comment.
Suggested change
| T* assert_dynamic_cast(U* ptr) | |
| T * assert_dynamic_cast(U * ptr) |
utils/zookeeper-test/main.cpp
Outdated
Member
There was a problem hiding this comment.
Suggested change
| T* result = dynamic_cast<T*>(ptr); | |
| T * result = dynamic_cast<T *>(ptr); |
Comment on lines
387
to
393
Member
There was a problem hiding this comment.
This can be written with ternary operator
Member
|
Continued in #41410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Not for changelog (changelog entry is not required)
Implemented multi-read support for get operation
Implemented multi-read support for simple list operation
Implemented server version check and fallback to loop-retry solution for old servers
Added multi-read support in ClickHouse Keeper