Properly cancel INSERT queries in clickhouse-client#36710
Merged
kssenii merged 2 commits intoClickHouse:masterfrom Apr 28, 2022
Merged
Properly cancel INSERT queries in clickhouse-client#36710kssenii merged 2 commits intoClickHouse:masterfrom
kssenii merged 2 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
This will also fix issues like queries left after the test, like in [1]. [1]: https://s3.amazonaws.com/clickhouse-test-reports/36686/042cf0c76444e8738eb2481ae21a135f05b4c990/stateless_tests__debug__actions__[2/3]/runlog.log Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
client-wait-insert
branch
from
352ef65 to
22189b0
Compare
Member
Author
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Member
Author
|
Member
|
Stress test (debug, actions) - see #36660 |
kssenii
approved these changes
Apr 28, 2022
yokofly
added a commit
to timeplus-io/proton
that referenced
this pull request
Nov 7, 2023
porting ClickHouse/ClickHouse#36710 (Apr 28, 2022)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Properly cancel INSERT queries in
clickhouse-client/clickhouse-localThis will also fix issues like queries left after the test, like in 1.