Fix vertical merges in wide parts#36707
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Apr 29, 2022
Merged
Conversation
robot-ch-test-poll2
added
the
pr-bugfix
|
|
||
| /// Add columns because we don't want to read empty blocks | ||
| injectRequiredColumns(storage, storage_snapshot, data_part, columns_to_read); | ||
| injectRequiredColumns(storage, storage_snapshot, data_part, /*with_subcolumns=*/ false, columns_to_read); |
Member
There was a problem hiding this comment.
Do I understand correctly that this is the most imprtant line?
Maybe add a comment explaining - why we should not inject subcolumns as required columns here?
Member
Author
There was a problem hiding this comment.
Yes. I can add a comment.
Actually the problem is not exactly that we shouldn't require subcolumns, because we will read only columns for requested names and there are no subcolumns. But subcolumn can be added as the smallest column in case when all requested columns are missing.
alexey-milovidov
approved these changes
Apr 28, 2022
Member
|
You can also pull this test: #36706 |
Member
Author
|
I've already added tests from #36706. If it's not important to keep the authorship of commits, we can close it. |
alexey-milovidov
added
the
pr-must-backport
This was referenced Apr 29, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 29, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 29, 2022
Felixoid
added a commit
that referenced
this pull request
Apr 29, 2022
Backport #36707 to 22.4: Fix vertical merges in wide parts
CurtizJ
added a commit
that referenced
this pull request
May 2, 2022
Backport #36707 to 22.3: Fix vertical merges in wide parts
kaynewu
added a commit
to kaynewu/ClickHouse
that referenced
this pull request
Jun 9, 2022
* Backport ClickHouse#36167 to 22.3: Fix broken aliases during parsing of special operators * Backport git fix for /build directory * Trigger CI * Update version to 22.3.5.20 * Backport ClickHouse#36637 to 22.3: Fix merges of wide parts with type `Object` * Backport ClickHouse#36487 to 22.3: Add passphrase for certificates * Backport ClickHouse#36707 to 22.3: Fix vertical merges in wide parts * Update version to 22.3.6.5 * Backport ClickHouse#36910 to 22.3: Fix bug in keeper which could lead to corrupted compressed logs * Update version to 22.3.7.5 * Backport ClickHouse#36866 to 22.3: Integration tests * Backport ClickHouse#35803 to 22.3: Fix bug in indexes of not presented columns in -WithNames formats * Backport ClickHouse#37021 to 22.3: Fixed problem with infs in `quantileTDigest` * Backport ClickHouse#36463 to 22.3: Ignore DNS errors when checking if dictionary source is local * Backport ClickHouse#37443 to 22.3: Functions normalize utf8 fix * Backport ClickHouse#37336 to 22.3: Fix clash of constant strings in aggregate function, prewhere and join * Backport ClickHouse#37690 to 22.3: Fix segfault with mysql db + show create table + named collections Co-authored-by: robot-clickhouse <[email protected]> Co-authored-by: Mikhail f. Shiryaev <[email protected]> Co-authored-by: Anton Popov <[email protected]> Co-authored-by: Maksim Kita <[email protected]> Co-authored-by: Alexey Milovidov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Kruglov Pavel <[email protected]> Co-authored-by: Alexander Tokmakov <[email protected]> Co-authored-by: Vladimir C <[email protected]> Co-authored-by: Kseniia Sumarokova <[email protected]>
Felixoid
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix vertical merges in wide parts. Previously an exception
There is no columncan be thrown during merge.Fixes #36687.