Skip to content

Fix some flaky tests#36644

Merged
tavplubix merged 2 commits intomasterfrom
fix_some_flaky_tests
Apr 26, 2022
Merged

Fix some flaky tests#36644
tavplubix merged 2 commits intomasterfrom
fix_some_flaky_tests

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Apr 25, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix failures like this:
https://s3.amazonaws.com/clickhouse-test-reports/36493/88f37ef34f89670b0c7a6d4333f5a5c9a99422a3/stateless_tests__release__actions_.html

2022-04-21 12:33:59 01174_select_insert_isolation:                                          [ FAIL ] 3.70 sec. - having stderror: 
2022-04-21 12:33:59 Error on processing query: Code: 75. DB::ErrnoException: Cannot write to file (fd = 1), errno: 32, strerror: Broken pipe. (CANNOT_WRITE_TO_FILE_DESCRIPTOR) (version 22.4.1.2311)
2022-04-21 12:33:59 (query: SELECT arraySort(groupArray(n)), arraySort(groupArray(m)), arraySort(groupArray(_part)) FROM mt;)

Also fixes #36381

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 25, 2022
@alexey-milovidov alexey-milovidov self-assigned this Apr 26, 2022
@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Apr 26, 2022

Stateless tests (release, wide parts enabled, actions) - 02180_group_by_lowcardinality - bd1f12e
Stateless tests flaky check (address, actions) - OK
Stress test (address, actions) - Backward compatibility check:

2022.04.26 03:30:10.820305 [ 241391 ] {} <Error> MutateFromLogEntryTask: virtual bool DB::ReplicatedMergeMutateTaskBase::executeStep(): Code: 47. DB::Exception: Missing columns: 'n.d' while processing query: '`n.d`, i32, s, k, dt, d', required columns: 'i32' 's' 'k' 'n.d' 'dt' 'd', maybe you meant: ['i32','s','k','dt','d']. (UNKNOWN_IDENTIFIER), Stack trace (when copying this message, always include the lines below):

Multiple ALTER MODIFY queries were executed and each query created a mutation. But the first mutation was killed and seem like that's why all subsequent mutations fail (it's expected behavior). So it's probably false-positive (not a backward compatibility issue), cc: @Avogar

@tavplubix tavplubix merged commit 190becd into master Apr 26, 2022
@tavplubix tavplubix deleted the fix_some_flaky_tests branch April 26, 2022 10:40
@tavplubix tavplubix mentioned this pull request Jun 3, 2022
Merged
@tavplubix tavplubix restored the fix_some_flaky_tests branch November 30, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Abort during ALTER TABLE ... ATTACH PART ... with transactions

3 participants

@tavplubix @alexey-milovidov @robot-clickhouse