Merged
Conversation
robot-clickhouse
added
the
pr-improvement
tavplubix
approved these changes
Apr 25, 2022
Comment on lines
+349
to
+358
| case Type::DROP_FILESYSTEM_CACHE: | ||
| { | ||
| ParserLiteral path_parser; | ||
| ASTPtr ast; | ||
| if (path_parser.parse(pos, ast, expected)) | ||
| res->filesystem_cache_path = ast->as<ASTLiteral>()->value.safeGet<String>(); | ||
| if (ParserKeyword{"FORCE"}.ignore(pos, expected)) | ||
| res->force_removal = true; | ||
| break; | ||
| } |
Member
There was a problem hiding this comment.
Don't forget to update ASTSystemQuery::formatImpl as well
src/Common/FileSegment.cpp
Outdated
Comment on lines
455
to
458
| assertNotDetached(); | ||
|
|
||
| std::lock_guard cache_lock(cache->mutex); | ||
| std::lock_guard segment_lock(mutex); |
Member
There was a problem hiding this comment.
It it ok to check it with unlocked mutexes?
Member
|
@kssenii, your forgot to take a look at failed tests before merging, you will find |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improve
SYSTEM DROP FILESYSTEM CACHEquery:<path>option andFORCEoption.