Changelog category (leave one):

• Bug Fix

Changelog entry:

In FileSegmentsHolder::~FileSegmentsHolder(), when a segment is set to detach, it will assert its state is empty. However, in FileSegment::completeImpl(), when detach is set to true, its state may be PARTIALLY_DOWNLOADED_NO_CONTINUATION or SKIP_CACHE or PARTIALLY_DOWNLOADED, thus cause error in FileSegmentsHolder::~FileSegmentsHolder().

if (file_segment->detached)
{
    /// This file segment is not owned by cache, so it will be destructed
    /// at this point, therefore no completion required.
    assert(file_segment->state() == FileSegment::State::EMPTY);
    file_segment_it = file_segments.erase(current_file_segment_it);
    continue;
}